forums.silverfrost.com

EKruck · Joined: 09 Jan 2010 Posts: 224 Location: Aalen, Germany

Compared to COMMON areas MODULS have very big advantages: They can be included in DLLs and they can hold dynamic allocatable arrays.
Our new developments use only MODULS but no COMMON at all.
We have a collection of global MODULS and several local MODULS for application programs.

When e.g. a global MODUL contains a variable iPosXYZ and a local MODULE includes a variable with the same name iPosXYZ and both moduls are used inside the same function we get no warning or error message but unexpected results. This is contrary to the use of COMMON areas from INCLUDE files.

Enhancement of the compiler will be appreciated.

Erwin

PaulLaidler · Posted: Fri Nov 09, 2012 10:20 am Post subject:

Thank you. I already have this as an issue to look at.

JohnCampbell · Joined: 16 Feb 2006 Posts: 2554 Location: Sydney

I'm puzzled. What do you expect the compiler should do in response to having the same variable name used in 2 modules?

davidb · Joined: 17 Jul 2009 Posts: 560 Location: UK

JohnCampbell · Joined: 16 Feb 2006 Posts: 2554 Location: Sydney

I have seen examples of duplicate variables, I think a variable name being both local and in a module.
I am not sure if this can be legally done, but it certainly is confusing code that I would not recommend.
My best adviced is don't do it. Fix it. There must be a way of changing the code to avoid this, even if it takes a bit of effort and checking with global editing.

John

davidb · Joined: 17 Jul 2009 Posts: 560 Location: UK

Having a local variable with the same name as one in a USED module is OK. The local variable can be accessed and the global one can't. It isn't good practise though.

I find the best practise is to always use ONLY with USE statements:

If I want to use a local variable with the same name as one in a module, I don't include it in the ONLY list.

If I want to use a variable in a module that has the same name as one of my local variables, I usually rename one of them in the editor, or occasionally (when the module is supplied in a library and I don't have the source code), I use the rename facility with USE and prepend the module name, e.g.

PaulLaidler · Posted: Sat Mar 16, 2013 3:40 pm Post subject:

Erwin

Now I have come to look at this, I can not find a sample program to illustrate the problem.

Can you supply some sample code so that I know exactly what is happening.

DanRRight · Posted: Sat Mar 16, 2013 10:05 pm Post subject: Re: Using Several Moduls